Skip to content

feat(shared-filesystem-storage): migrates error_messages to functional TypeScript#1987

Merged
andypf merged 5 commits into
masterfrom
hoda-elektra-react-19-error-messages-list
May 13, 2026
Merged

feat(shared-filesystem-storage): migrates error_messages to functional TypeScript#1987
andypf merged 5 commits into
masterfrom
hoda-elektra-react-19-error-messages-list

Conversation

@hodanoori
Copy link
Copy Markdown
Contributor

@hodanoori hodanoori commented Mar 31, 2026

Summary

Migrates ErrorMessageList and ErrorMessageItem components in the shared filesystem storage plugin from class components to functional TypeScript components as part of the React 19 migration epic (#1774).

Changes Made

  • Replace class component ErrorMessageList with a functional TypeScript component in list.tsx
  • Replace class component ErrorMessageItem with a functional TypeScript component in item.tsx
  • Convert class state (show, showDetails) to useState hooks
  • Replace componentDidMount and UNSAFE_componentWillReceiveProps with useEffect
  • Remove unused imports (policy, DefeatableLink) carried over from the original class components
  • Add TypeScript interfaces for ErrorMessage, ErrorMessagesState, Match, History, and component props
  • Add list.test.tsx with 14 unit tests covering rendering, loading state, table content, and close behaviour
  • Add item.test.tsx with 9 unit tests covering row rendering and details toggle

Related Issues

Screenshots (if applicable)

41E5549C-E474-45B8-A7DF-8465C049FCEB

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@hodanoori hodanoori self-assigned this Mar 31, 2026
@andypf andypf enabled auto-merge (squash) May 13, 2026 14:10
@andypf andypf merged commit 869af57 into master May 13, 2026
21 checks passed
@andypf andypf deleted the hoda-elektra-react-19-error-messages-list branch May 13, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task](shared-file-system-storage-list): Migrate shared_filesystem_storage/components/error_messages/list.jsx

3 participants